8499a32859
lintcheck: add -j <N> option to configure threads.
...
defaults to 1
-j 0 choses the number of threads automtically (= number of physical cores)
2021-02-19 23:20:05 +01:00
22aeec09e4
lintcheck: sort crates before linting
2021-02-19 22:16:53 +01:00
4974734a24
lintcheck: show progress percentage in the "Linting..." message
2021-02-19 22:06:50 +01:00
d198551311
lintheck: show output (and compiler errors!) when compiling clippy for lintcheck
2021-02-19 21:52:34 +01:00
bb5f9d18a0
lintcheck: tweak some comments
2021-02-19 21:48:52 +01:00
90d3275b45
lintcheck: parallelize
...
Use rayon to figure out the threadcount and half that for core count.
For each core, create a target dir that is used.
Otherwise, when running multiple clippys with the same target-dir, cargo would lock the dir and prevent parallelism.
This way we can run multiple clippys at the same time (on root crates) but we sacrifice cache-hits (when we already cargo-checked crate-deps).
2021-02-19 00:14:43 +01:00
dd5c9b7dda
lintcheck: Slight improvements to the error reporting
2021-02-16 16:58:00 +01:00
2a28ea0bea
Add command line options option to lintcheck crates config
2021-02-16 16:57:30 +01:00
028692b46a
lintcheck: filter out messages that come from cargo-metadata errors or contain absolute paths to rustc source files
...
The latter is especially annoying because the paths would change every time we bumped the pinned nightly version.
2021-02-15 23:38:50 +01:00
8f1cceb6ff
lintcheck: print warnings if we can't check out or clone a git repo
2021-02-15 22:48:33 +01:00
f8dbcae9f4
lintcheck: fix bug in downloade_and_extract() for git sources: we need to execute "git checkout xy" inside the repo dir!
2021-02-15 22:48:32 +01:00
214d821268
lintcheck: put some code into a gather_stats() function
2021-02-15 22:13:17 +01:00
4856e5f8fc
lintcheck: rename a few symbols, add documentation to functions
2021-02-15 22:13:17 +01:00
1b74439871
lintcheck: rename struct field
2021-02-15 22:13:17 +01:00
5bbb1bc20a
lintcheck: env var LINTCHECK_TOML can be used to override toml file location (has precedence over --crates-toml flag)
2021-02-13 00:39:19 +01:00
a6d493d52a
lintcheck: collect ICEs
2021-02-11 10:43:06 +01:00
5e29aa6fdf
lintcheck: add support for path sources
2021-02-11 10:43:04 +01:00
c7241b6e5e
lintcheck: make the log file be ${source-file}-logs.txt
...
this allows us to check multiple source.tomls and not worry about overriding our logfiles accidentally
2021-02-11 10:41:31 +01:00
6f3eeac83c
lintcheck: add a cmdline option --crates-toml <TOML PATH> to override crate sources file to use.
...
Fixes #6691
2021-02-07 16:14:43 +01:00
c1ce78f0b2
Auto merge of #6686 - matthiaskrgr:lintcheck_git, r=flip1995
...
lintcheck: support git sources
This adds support for git sources in `cargo dev-lintcheck`
You can add a git source to `clippy_dev/lintcheck_crates.toml` by having a `git_url` and a `git_hash` key instead of the `versions` array.
The repo will the be cloned and checked out to the requested commit before checking it with clippy.
Fixes https://github.com/rust-lang/rust-clippy/issues/6642
changelog: lintcheck: support git sources
2021-02-07 13:25:00 +00:00
d792210c26
Auto merge of #6682 - camsteffen:let-underscore-ref, r=llogiq
...
Fix let_underscore_drop FP
changelog: Fix let_underscore_drop false positives and negatives
Fixes #6633
2021-02-07 08:13:42 +00:00
40ce05654b
Eat dogfood
2021-02-06 16:35:38 -06:00
2bffbfccc1
lintcheck: avoid dbg!() calls
2021-02-06 19:12:58 +01:00
e1c284bff7
lintcheck: cleanup, fix --only for git crates, better error msgs
2021-02-06 12:24:13 +01:00
9ab505a3c7
lintcheck: add git source as an example and update logs
2021-02-06 12:11:31 +01:00
10fbafa562
implement the download_and_extract() step for git sources
2021-02-06 12:10:47 +01:00
64982cc435
lintcheck: make TomlCrate also accept git-data from lintcheck_crates.toml
2021-02-06 12:10:45 +01:00
79dbf10736
Use absolute path to Rust repo in ra_setup
...
This will convert the path to the Rust repo to an absolute path. This is
important for the clippy_lints/Cargo.toml file. Otherwise if a relative
path is passed, rst-analyzer won't find the Rust repo, because it starts
the relative path search from the clippy_lints dir, not the
rust-clippy dir where the ra_setup command was run from.
2021-02-05 17:23:04 +01:00
bde667af7e
Add missing_panics_doc lint
2021-02-02 16:36:32 +01:00
da26b2149f
clippy_dev: Pass stderr to CommandFailed
2021-01-31 11:21:33 +01:00
5b6a18362b
lintcheck: fix paths in the logs
2021-01-23 02:18:11 +01:00
83fcf95f52
rename cargo dev crater to cargo dev lintcheck
2021-01-23 02:18:11 +01:00
48fc948ca3
clippy dev crater: address more review commetns
...
make serde a feature-dep
save clippy version in the crater log
2021-01-23 02:18:11 +01:00
ec1902ce43
cargo dev crater: throw an error if we can't find our specified crate in the .toml list
2021-01-23 02:18:11 +01:00
b6ef1e282e
clippy dev crater: add option to only check a single one of the listed crates with --only crate
2021-01-23 02:18:11 +01:00
d257101109
make stats stable
2021-01-23 02:18:11 +01:00
e56c9a5253
cargo dev crater: gather and save lint statistics (how often a lint triggered)
2021-01-23 02:18:11 +01:00
4ec9cb84bb
cargo dev crater: refactor to get a list of all ClippyWarnings
2021-01-23 02:18:11 +01:00
6c5bf2778f
clippy dev crater: use and parse clippy messages as json message, to get the lint name of a warning
2021-01-23 02:18:11 +01:00
62337f2842
remove duplicate code and other cleanup
2021-01-23 02:18:11 +01:00
22824d21da
rename symbols: krate -> crate
2021-01-23 02:18:11 +01:00
f986d78c5e
cargo dev crater: support multiple versions per crate
2021-01-23 02:18:11 +01:00
588efa7da9
use a .toml file to list the crates we want to check
...
Also sort lint results alphabetically.
2021-01-23 02:18:11 +01:00
a9fce6d2d0
allow clippy::filter_map
2021-01-23 02:18:11 +01:00
ccfaa338ed
cargo dev crater: share target dir between clippy runs, enable pedantic and cargo lints, ignore tokei for now.
2021-01-23 02:18:11 +01:00
1e5ac1dfd2
cargo dev crater: add more crates to be checked
2021-01-23 02:18:11 +01:00
dbb8c0020e
cargo dev crater: save all warnings into a file
2021-01-23 02:18:11 +01:00
7314133722
cargo dev crater: cleanup, don't re-download and reextract crates on every run
2021-01-23 02:18:11 +01:00
734d2052df
print all clippy warnings in the end
2021-01-23 02:18:11 +01:00
2360a7cad0
cargo clippy dev: collecting one-line clippy warnings works now
2021-01-23 02:18:11 +01:00
Matthias Krüger