From f56841d974056509969180e03c528963b2a76481 Mon Sep 17 00:00:00 2001 From: Ralf Jung Date: Thu, 30 Aug 2018 15:57:17 +0200 Subject: [PATCH] unignore a bunch of tests that actually work --- tests/compile-fail/invalid_bool.rs | 2 +- tests/compile-fail/match_char.rs | 2 +- tests/compile-fail/panic.rs | 1 - tests/run-pass-fullmir/catch.rs | 3 +-- tests/run-pass-fullmir/foreign-fn-linkname.rs | 2 +- tests/run-pass-fullmir/format.rs | 3 +-- tests/run-pass-fullmir/from_utf8.rs | 1 - tests/run-pass-fullmir/hashmap.rs | 1 - tests/run-pass-fullmir/hello.rs | 3 +-- tests/run-pass-fullmir/integer-ops.rs | 3 +-- tests/run-pass-fullmir/issue-3794.rs | 3 +-- tests/run-pass-fullmir/loop-break-value.rs | 2 -- .../send-is-not-static-par-for.rs | 2 -- tests/run-pass-fullmir/u128.rs | 2 -- tests/run-pass-fullmir/unsized-tuple-impls.rs | 2 -- tests/run-pass/heap.rs | 1 - tests/run-pass/issue-15080.rs | 2 -- tests/run-pass/issue-17877.rs | 3 ++- tests/run-pass/move-arg-2-unique.rs | 2 -- tests/run-pass/regions-mock-trans.rs | 2 +- tests/run-pass/thread-local.rs | 2 +- tests/run-pass/vecs.rs | 2 -- 22 files changed, 12 insertions(+), 34 deletions(-) rename tests/{run-pass => run-pass-fullmir}/send-is-not-static-par-for.rs (98%) diff --git a/tests/compile-fail/invalid_bool.rs b/tests/compile-fail/invalid_bool.rs index bd08c0ce4eb9..49328ef5d74e 100644 --- a/tests/compile-fail/invalid_bool.rs +++ b/tests/compile-fail/invalid_bool.rs @@ -1,4 +1,4 @@ -//ignore-test FIXME (do some basic validation of invariants for all values in flight) +//ignore-test FIXME: do some basic validation of invariants for all values in flight //This does currently not get caught becuase it compiles to SwitchInt, which //has no knowledge about data invariants. diff --git a/tests/compile-fail/match_char.rs b/tests/compile-fail/match_char.rs index fd4431992d9b..e7fee1e3e361 100644 --- a/tests/compile-fail/match_char.rs +++ b/tests/compile-fail/match_char.rs @@ -1,4 +1,4 @@ -// ignore-test FIXME: we are not checking these things on match any more? +//ignore-test FIXME: do some basic validation of invariants for all values in flight //This does currently not get caught becuase it compiles to SwitchInt, which //has no knowledge about data invariants. diff --git a/tests/compile-fail/panic.rs b/tests/compile-fail/panic.rs index 1f9e8f6e1d0b..80149eeffaa6 100644 --- a/tests/compile-fail/panic.rs +++ b/tests/compile-fail/panic.rs @@ -1,4 +1,3 @@ -//ignore-windows // FIXME: Something in panic handling fails validation with full-MIR // compile-flags: -Zmir-emit-validate=0 //error-pattern: the evaluated program panicked diff --git a/tests/run-pass-fullmir/catch.rs b/tests/run-pass-fullmir/catch.rs index 60c86c99e9aa..960297daa7ef 100644 --- a/tests/run-pass-fullmir/catch.rs +++ b/tests/run-pass-fullmir/catch.rs @@ -1,5 +1,4 @@ -//ignore-msvc -//ignore-macos +//ignore-msvc: Stdout not implemented on Windows use std::panic::{catch_unwind, AssertUnwindSafe}; fn main() { diff --git a/tests/run-pass-fullmir/foreign-fn-linkname.rs b/tests/run-pass-fullmir/foreign-fn-linkname.rs index 20cb713590c9..789e3eccceb7 100644 --- a/tests/run-pass-fullmir/foreign-fn-linkname.rs +++ b/tests/run-pass-fullmir/foreign-fn-linkname.rs @@ -8,7 +8,7 @@ // option. This file may not be copied, modified, or distributed // except according to those terms. -//ignore-msvc +//ignore-windows: Uses POSIX APIs #![feature(libc)] extern crate libc; diff --git a/tests/run-pass-fullmir/format.rs b/tests/run-pass-fullmir/format.rs index 59af803b59f0..b1b05abd2965 100644 --- a/tests/run-pass-fullmir/format.rs +++ b/tests/run-pass-fullmir/format.rs @@ -1,5 +1,4 @@ -//ignore-msvc -//ignore-macos +//ignore-msvc: Stdout not implemented on Windows fn main() { println!("Hello {}", 13); } diff --git a/tests/run-pass-fullmir/from_utf8.rs b/tests/run-pass-fullmir/from_utf8.rs index c5d4abcfdaef..69e6c521af6e 100644 --- a/tests/run-pass-fullmir/from_utf8.rs +++ b/tests/run-pass-fullmir/from_utf8.rs @@ -1,4 +1,3 @@ -//ignore-msvc fn main() { let _ = ::std::str::from_utf8(b"a"); } diff --git a/tests/run-pass-fullmir/hashmap.rs b/tests/run-pass-fullmir/hashmap.rs index 99f05e25985e..f4a358174f55 100644 --- a/tests/run-pass-fullmir/hashmap.rs +++ b/tests/run-pass-fullmir/hashmap.rs @@ -1,4 +1,3 @@ -//ignore-msvc use std::collections::{self, HashMap}; use std::hash::BuildHasherDefault; diff --git a/tests/run-pass-fullmir/hello.rs b/tests/run-pass-fullmir/hello.rs index a0d73733bdfc..c92c1567f5ae 100644 --- a/tests/run-pass-fullmir/hello.rs +++ b/tests/run-pass-fullmir/hello.rs @@ -1,5 +1,4 @@ -//ignore-msvc -//ignore-macos +//ignore-msvc: Stdout not implemented on Windows fn main() { println!("Hello, world!"); } diff --git a/tests/run-pass-fullmir/integer-ops.rs b/tests/run-pass-fullmir/integer-ops.rs index 97c694fd5674..7a2335c829ef 100644 --- a/tests/run-pass-fullmir/integer-ops.rs +++ b/tests/run-pass-fullmir/integer-ops.rs @@ -11,7 +11,6 @@ // FIXME: remove -Zmir-opt-level once https://github.com/rust-lang/rust/issues/43359 is fixed // compile-flags: -Zmir-opt-level=0 -//ignore-msvc use std::i32; pub fn main() { @@ -168,7 +167,7 @@ pub fn main() { assert_eq!(0x10i32.overflowing_shr(4), (0x1, false)); assert_eq!(0x10i32.overflowing_shr(36), (0x1, true)); - + assert_eq!(10i8.overflowing_abs(), (10,false)); assert_eq!((-10i8).overflowing_abs(), (10,false)); assert_eq!((-128i8).overflowing_abs(), (-128,true)); diff --git a/tests/run-pass-fullmir/issue-3794.rs b/tests/run-pass-fullmir/issue-3794.rs index 8b653f0f95fc..32b4d27f11f5 100644 --- a/tests/run-pass-fullmir/issue-3794.rs +++ b/tests/run-pass-fullmir/issue-3794.rs @@ -8,8 +8,7 @@ // option. This file may not be copied, modified, or distributed // except according to those terms. -//ignore-msvc -//ignore-macos +//ignore-msvc: Stdout not implemented on Windows #![feature(box_syntax)] trait T { diff --git a/tests/run-pass-fullmir/loop-break-value.rs b/tests/run-pass-fullmir/loop-break-value.rs index 8a0ea113c5d6..8631909a2a96 100644 --- a/tests/run-pass-fullmir/loop-break-value.rs +++ b/tests/run-pass-fullmir/loop-break-value.rs @@ -8,8 +8,6 @@ // option. This file may not be copied, modified, or distributed // except according to those terms. -//ignore-msvc - #![feature(never_type)] #![allow(unreachable_code)] diff --git a/tests/run-pass/send-is-not-static-par-for.rs b/tests/run-pass-fullmir/send-is-not-static-par-for.rs similarity index 98% rename from tests/run-pass/send-is-not-static-par-for.rs rename to tests/run-pass-fullmir/send-is-not-static-par-for.rs index 4ac1b5436f52..1b913aed4c89 100644 --- a/tests/run-pass/send-is-not-static-par-for.rs +++ b/tests/run-pass-fullmir/send-is-not-static-par-for.rs @@ -8,8 +8,6 @@ // option. This file may not be copied, modified, or distributed // except according to those terms. -//ignore-windows - use std::sync::Mutex; fn par_for(iter: I, f: F) diff --git a/tests/run-pass-fullmir/u128.rs b/tests/run-pass-fullmir/u128.rs index d7764bf6201a..ca33bd5f9e3d 100644 --- a/tests/run-pass-fullmir/u128.rs +++ b/tests/run-pass-fullmir/u128.rs @@ -8,8 +8,6 @@ // option. This file may not be copied, modified, or distributed // except according to those terms. -//ignore-msvc - fn b(t: T) -> T { t } fn main() { diff --git a/tests/run-pass-fullmir/unsized-tuple-impls.rs b/tests/run-pass-fullmir/unsized-tuple-impls.rs index 828e5c26927e..ccb6883e8733 100644 --- a/tests/run-pass-fullmir/unsized-tuple-impls.rs +++ b/tests/run-pass-fullmir/unsized-tuple-impls.rs @@ -8,8 +8,6 @@ // option. This file may not be copied, modified, or distributed // except according to those terms. -//ignore-msvc - #![feature(unsized_tuple_coercion)] use std::mem; diff --git a/tests/run-pass/heap.rs b/tests/run-pass/heap.rs index 917d51d0e4b6..b533f9164698 100644 --- a/tests/run-pass/heap.rs +++ b/tests/run-pass/heap.rs @@ -1,4 +1,3 @@ -//ignore-msvc #![feature(box_syntax)] fn make_box() -> Box<(i16, i16)> { diff --git a/tests/run-pass/issue-15080.rs b/tests/run-pass/issue-15080.rs index 4a84f2bc5d62..b5b1edcfddd0 100644 --- a/tests/run-pass/issue-15080.rs +++ b/tests/run-pass/issue-15080.rs @@ -8,8 +8,6 @@ // option. This file may not be copied, modified, or distributed // except according to those terms. -//ignore-msvc - #![feature(slice_patterns)] fn main() { diff --git a/tests/run-pass/issue-17877.rs b/tests/run-pass/issue-17877.rs index b4b74b9905fb..762bacbe0e6f 100644 --- a/tests/run-pass/issue-17877.rs +++ b/tests/run-pass/issue-17877.rs @@ -8,7 +8,8 @@ // option. This file may not be copied, modified, or distributed // except according to those terms. -//ignore-msvc +//ignore-windows: Causes a stack overflow?!? Likely a rustc bug: https://github.com/rust-lang/rust/issues/53820 +//Once that bug is fixed, increase the size to 16*1024 and enable on all platforms. #![feature(slice_patterns)] diff --git a/tests/run-pass/move-arg-2-unique.rs b/tests/run-pass/move-arg-2-unique.rs index f3c656623765..d44c83763b7c 100644 --- a/tests/run-pass/move-arg-2-unique.rs +++ b/tests/run-pass/move-arg-2-unique.rs @@ -8,8 +8,6 @@ // option. This file may not be copied, modified, or distributed // except according to those terms. -//ignore-msvc - #![allow(unused_features, unused_variables)] #![feature(box_syntax)] diff --git a/tests/run-pass/regions-mock-trans.rs b/tests/run-pass/regions-mock-trans.rs index 74e94ddbf84f..039175e9acd6 100644 --- a/tests/run-pass/regions-mock-trans.rs +++ b/tests/run-pass/regions-mock-trans.rs @@ -11,7 +11,7 @@ // FIXME: We handle uninitialized storage here, which currently makes validation fail. // compile-flags: -Zmir-emit-validate=0 -//ignore-msvc +//ignore-windows: Uses POSIX APIs #![feature(libc)] diff --git a/tests/run-pass/thread-local.rs b/tests/run-pass/thread-local.rs index db00e42d99ac..8c20e89ab52d 100644 --- a/tests/run-pass/thread-local.rs +++ b/tests/run-pass/thread-local.rs @@ -1,4 +1,4 @@ -//ignore-windows +//ignore-windows: Uses POSIX APIs #![feature(libc)] extern crate libc; diff --git a/tests/run-pass/vecs.rs b/tests/run-pass/vecs.rs index 9a8912a6b988..776791bbc9b9 100644 --- a/tests/run-pass/vecs.rs +++ b/tests/run-pass/vecs.rs @@ -1,5 +1,3 @@ -//ignore-msvc - fn make_vec() -> Vec { let mut v = Vec::with_capacity(4); v.push(1);