From bfcb2909372d4bd1dbd718dbcf3a5eec96a10c62 Mon Sep 17 00:00:00 2001
From: Nick Cameron <ncameron@mozilla.com>
Date: Fri, 22 Sep 2017 14:41:22 +1200
Subject: [PATCH] Add RLS and Rustfmt to the toolstate mechanism

---
 src/bootstrap/check.rs     | 12 ++++++++++--
 src/bootstrap/tool.rs      |  4 ++--
 src/bootstrap/toolstate.rs |  2 ++
 src/tools/toolstate.toml   |  7 +++++++
 4 files changed, 21 insertions(+), 4 deletions(-)

diff --git a/src/bootstrap/check.rs b/src/bootstrap/check.rs
index 21e7a0523626..6e276f44668f 100644
--- a/src/bootstrap/check.rs
+++ b/src/bootstrap/check.rs
@@ -254,7 +254,11 @@ fn run(self, builder: &Builder) {
 
         builder.add_rustc_lib_path(compiler, &mut cargo);
 
-        try_run(build, &mut cargo);
+        try_run_expecting(
+            build,
+            &mut cargo,
+            builder.build.config.toolstate.rls.passes(ToolState::Testing),
+        );
     }
 }
 
@@ -295,7 +299,11 @@ fn run(self, builder: &Builder) {
 
         builder.add_rustc_lib_path(compiler, &mut cargo);
 
-        try_run(build, &mut cargo);
+        try_run_expecting(
+            build,
+            &mut cargo,
+            builder.build.config.toolstate.rustfmt.passes(ToolState::Testing),
+        );
     }
 }
 
diff --git a/src/bootstrap/tool.rs b/src/bootstrap/tool.rs
index e07ffea2a2ee..19879ab2ade3 100644
--- a/src/bootstrap/tool.rs
+++ b/src/bootstrap/tool.rs
@@ -454,7 +454,7 @@ fn run(self, builder: &Builder) -> PathBuf {
             tool: "rls",
             mode: Mode::Librustc,
             path: "src/tools/rls",
-            expectation: BuildExpectation::None,
+            expectation: builder.build.config.toolstate.rls.passes(ToolState::Compiling),
         })
     }
 }
@@ -489,7 +489,7 @@ fn run(self, builder: &Builder) -> PathBuf {
             tool: "rustfmt",
             mode: Mode::Librustc,
             path: "src/tools/rustfmt",
-            expectation: BuildExpectation::None,
+            expectation: builder.build.config.toolstate.rustfmt.passes(ToolState::Compiling),
         })
     }
 }
diff --git a/src/bootstrap/toolstate.rs b/src/bootstrap/toolstate.rs
index 0711c034602b..8a113f6b4d2d 100644
--- a/src/bootstrap/toolstate.rs
+++ b/src/bootstrap/toolstate.rs
@@ -46,4 +46,6 @@ fn default() -> Self {
 pub struct ToolStates {
     pub miri: ToolState,
     pub clippy: ToolState,
+    pub rls: ToolState,
+    pub rustfmt: ToolState,
 }
diff --git a/src/tools/toolstate.toml b/src/tools/toolstate.toml
index 3cc815ef34ed..1700daa0aff1 100644
--- a/src/tools/toolstate.toml
+++ b/src/tools/toolstate.toml
@@ -27,3 +27,10 @@ miri = "Broken"
 
 # ping @Manishearth @llogiq @mcarton @oli-obk
 clippy = "Broken"
+
+# ping @nrc
+rls = "Testing"
+
+# ping @nrc
+rustfmt = "Testing"
+