diff --git a/src/libcollections/btree/map.rs b/src/libcollections/btree/map.rs index b0ba22546215..ab1605954337 100644 --- a/src/libcollections/btree/map.rs +++ b/src/libcollections/btree/map.rs @@ -46,12 +46,12 @@ struct AbsEntries { } /// An iterator over a BTreeMap's entries. -pub struct Entries<'a, K, V> { +pub struct Entries<'a, K: 'a, V: 'a> { inner: AbsEntries> } /// A mutable iterator over a BTreeMap's entries. -pub struct MutEntries<'a, K, V> { +pub struct MutEntries<'a, K: 'a, V: 'a> { inner: AbsEntries> } diff --git a/src/libcollections/vec.rs b/src/libcollections/vec.rs index 280fbdeffa23..f5d61a644a3c 100644 --- a/src/libcollections/vec.rs +++ b/src/libcollections/vec.rs @@ -791,11 +791,16 @@ pub fn move_iter(self) -> MoveItems { #[inline] pub fn into_iter(self) -> MoveItems { unsafe { - let iter = mem::transmute(self.as_slice().iter()); let ptr = self.ptr; let cap = self.cap; + let begin = self.ptr as *const T; + let end = if mem::size_of::() == 0 { + (ptr as uint + self.len()) as *const T + } else { + ptr.offset(self.len() as int) as *const T + }; mem::forget(self); - MoveItems { allocation: ptr, cap: cap, iter: iter } + MoveItems { allocation: ptr, cap: cap, ptr: begin, end: end } } } @@ -1719,7 +1724,8 @@ fn pop(&mut self) -> Option { pub struct MoveItems { allocation: *mut T, // the block of memory allocated for the vector cap: uint, // the capacity of the vector - iter: Items<'static, T> + ptr: *const T, + end: *const T } impl MoveItems { @@ -1728,7 +1734,7 @@ impl MoveItems { pub fn unwrap(mut self) -> Vec { unsafe { for _x in self { } - let MoveItems { allocation, cap, iter: _iter } = self; + let MoveItems { allocation, cap, ptr: _ptr, end: _end } = self; mem::forget(self); Vec { ptr: allocation, cap: cap, len: 0 } } @@ -1739,17 +1745,33 @@ impl Iterator for MoveItems { #[inline] fn next<'a>(&'a mut self) -> Option { unsafe { - // Unsafely transmute from Items<'static, T> to Items<'a, - // T> because otherwise the type checker requires that T - // be bounded by 'static. - let iter: &mut Items<'a, T> = mem::transmute(&mut self.iter); - iter.next().map(|x| ptr::read(x)) + if self.ptr == self.end { + None + } else { + if mem::size_of::() == 0 { + // purposefully don't use 'ptr.offset' because for + // vectors with 0-size elements this would return the + // same pointer. + self.ptr = mem::transmute(self.ptr as uint + 1); + + // Use a non-null pointer value + Some(ptr::read(mem::transmute(1u))) + } else { + let old = self.ptr; + self.ptr = self.ptr.offset(1); + + Some(ptr::read(old)) + } + } } } #[inline] fn size_hint(&self) -> (uint, Option) { - self.iter.size_hint() + let diff = (self.end as uint) - (self.ptr as uint); + let size = mem::size_of::(); + let exact = diff / (if size == 0 {1} else {size}); + (exact, Some(exact)) } } @@ -1757,11 +1779,21 @@ impl DoubleEndedIterator for MoveItems { #[inline] fn next_back<'a>(&'a mut self) -> Option { unsafe { - // Unsafely transmute from Items<'static, T> to Items<'a, - // T> because otherwise the type checker requires that T - // be bounded by 'static. - let iter: &mut Items<'a, T> = mem::transmute(&mut self.iter); - iter.next_back().map(|x| ptr::read(x)) + if self.end == self.ptr { + None + } else { + if mem::size_of::() == 0 { + // See above for why 'ptr.offset' isn't used + self.end = mem::transmute(self.end as uint - 1); + + // Use a non-null pointer value + Some(ptr::read(mem::transmute(1u))) + } else { + self.end = self.end.offset(-1); + + Some(ptr::read(mem::transmute(self.end))) + } + } } } } @@ -2473,6 +2505,36 @@ fn test_map_in_place_zero_sized() { assert_eq!(v.map_in_place(|_| ZeroSized).as_slice(), [ZeroSized, ZeroSized].as_slice()); } + #[test] + fn test_move_items() { + let mut vec = vec!(1i, 2, 3); + let mut vec2 : Vec = vec!(); + for i in vec.into_iter() { + vec2.push(i); + } + assert!(vec2 == vec!(1i, 2, 3)); + } + + #[test] + fn test_move_items_reverse() { + let mut vec = vec!(1i, 2, 3); + let mut vec2 : Vec = vec!(); + for i in vec.into_iter().rev() { + vec2.push(i); + } + assert!(vec2 == vec!(3i, 2, 1)); + } + + #[test] + fn test_move_items_zero_sized() { + let mut vec = vec!((), (), ()); + let mut vec2 : Vec<()> = vec!(); + for i in vec.into_iter() { + vec2.push(i); + } + assert!(vec2 == vec!((), (), ())); + } + #[bench] fn bench_new(b: &mut Bencher) { b.iter(|| { diff --git a/src/libcore/slice.rs b/src/libcore/slice.rs index 1a00107a2163..9f925f9d371a 100644 --- a/src/libcore/slice.rs +++ b/src/libcore/slice.rs @@ -1218,7 +1218,7 @@ fn next_back(&mut self) -> Option<$elem> { /// Immutable slice iterator #[experimental = "needs review"] -pub struct Items<'a, T> { +pub struct Items<'a, T: 'a> { ptr: *const T, end: *const T, marker: marker::ContravariantLifetime<'a> @@ -1261,7 +1261,7 @@ fn idx(&mut self, index: uint) -> Option<&'a T> { /// Mutable slice iterator. #[experimental = "needs review"] -pub struct MutItems<'a, T> { +pub struct MutItems<'a, T: 'a> { ptr: *mut T, end: *mut T, marker: marker::ContravariantLifetime<'a>,