From 87faa212fbc9f80daec903aa1bab1f997897bec4 Mon Sep 17 00:00:00 2001
From: Michael Howell <michael@notriddle.com>
Date: Tue, 9 Apr 2024 17:26:59 -0700
Subject: [PATCH] rustdoc: remove unused 16x16 favicon

According to <https://caniuse.com/?search=svg%20favicon>,
SVG favicons are supported in everything but Safari.

When I actually try it in Safari, it's downloading all
three favicons, and nothing looks different when I disable
the 16x16 one.

<https://dev.to/masakudamatsu/favicon-nightmare-how-to-maintain-sanity-3al7>,
which is linked from caniuse above, recommends an ico.
However, the reason they recommend it is the apps that
only support /favicon.ico exactly, and rustdoc can't assume
it will be installed to the site root, so it's unfortunately
up to the webmaster to make sure it's set up.
---
 .../html/static/images/favicon-16x16.png          | Bin 715 -> 0 bytes
 src/librustdoc/html/static_files.rs               |   1 -
 src/librustdoc/html/templates/page.html           |   2 --
 3 files changed, 3 deletions(-)
 delete mode 100644 src/librustdoc/html/static/images/favicon-16x16.png

diff --git a/src/librustdoc/html/static/images/favicon-16x16.png b/src/librustdoc/html/static/images/favicon-16x16.png
deleted file mode 100644
index ea4b45cae1618e6e20e6d61897da953f34b66b30..0000000000000000000000000000000000000000
GIT binary patch
literal 0
HcmV?d00001

literal 715
zcmeAS@N?(olHy`uVBq!ia0vp^0wB!60wlNoGJgf6SkfJR9T^xl_H+M9WCijSl0AZa
z85pY67#JE_7#My5g&JNkFq9fFFuY1&V6d9Oz#v{QXIG#NP=YDR+ueoXe|!I#{XiaP
zfk$L9P|ym58ULAS1_A}yOFVsD*`G1;@(QxEEo<Avz`$tc>EaloaX$3oUhmn3B1b>^
zXS8u>Ub4$r*u2F1FEiJ>rQJ&x%<Y=FM8C1G^joUO_D7GDGMd(9iMKncvrl|5qeHc^
zPcX)3zKN3Pq!;HEO^;Pi<DOn^F(?1f+a<jbmnI0Dv@U*lFJ*0aX=rHa(Q7H}=ebWc
zP15)BdM2|g%&h)<?UJ|35=JaVx3p}hZ)tka|EuBK-YLav6@1--V|~2~-bMJj2Yhz%
z4Q}(@C_DKZ3%i`;*VuwbTXQ$^PGfz)LH$c<CYy27Qx%K9^4s4n56oX`b6mS+iN|sE
z^EPhYC;5}(eym9j3%|l$X_{dFFuLA;x@XpniJM<<=MG;H{qg#S!r(H~D%VgJ*Z05A
z)&+=6Nv&*%SMu+j@y-9#4D(NNSvNOXajagkQkUb_EUxVvguWN(cd<@fU%n%sL2+6G
z7n8p2a$umUmbgZgq$HN4S|t~y0x1R~10y3{14CUy;}An*D?@WD19NQy11kfAxdrMX
zC>nC}Q!>*kacg*^JAVaGgCxj?;QX|b^2DN4hVt@qz0ADq;^f4FRK5J7^x5xhq=1UT
zt3o15f)dLW3X1a6GILTDN-7Id6*3D-k{K8(<~;ty!%-Nfp>fLp^cl~mK@7~w+<M8}
z!pg$llSP<?6<iuj4yQ0HZw^s7edEfBBWI4t9AQ7*;IY6<kKvWLV96&Z)2To!7(8A5
KT-G@yGywo1bOmw%

diff --git a/src/librustdoc/html/static_files.rs b/src/librustdoc/html/static_files.rs
index ca9a78f51b38..d8874c2fda0a 100644
--- a/src/librustdoc/html/static_files.rs
+++ b/src/librustdoc/html/static_files.rs
@@ -106,7 +106,6 @@ pub(crate) fn for_each<E>(f: impl Fn(&StaticFile) -> Result<(), E>) -> Result<()
     license_mit => "static/LICENSE-MIT.txt",
     rust_logo_svg => "static/images/rust-logo.svg",
     rust_favicon_svg => "static/images/favicon.svg",
-    rust_favicon_png_16 => "static/images/favicon-16x16.png",
     rust_favicon_png_32 => "static/images/favicon-32x32.png",
     fira_sans_regular => "static/fonts/FiraSans-Regular.woff2",
     fira_sans_medium => "static/fonts/FiraSans-Medium.woff2",
diff --git a/src/librustdoc/html/templates/page.html b/src/librustdoc/html/templates/page.html
index 0e7f7ab2b100..0941f758de57 100644
--- a/src/librustdoc/html/templates/page.html
+++ b/src/librustdoc/html/templates/page.html
@@ -58,8 +58,6 @@
     {% if !layout.favicon.is_empty() %}
         <link rel="icon" href="{{layout.favicon}}"> {# #}
     {% else %}
-        <link rel="alternate icon" type="image/png" {#+ #}
-            href="{{static_root_path|safe}}{{files.rust_favicon_png_16}}"> {# #}
         <link rel="alternate icon" type="image/png" {#+ #}
             href="{{static_root_path|safe}}{{files.rust_favicon_png_32}}"> {# #}
         <link rel="icon" type="image/svg+xml" {#+ #}