Account for union

2026-05-21 17:52:12 +03:00 · 2021-01-30 14:18:50 +09:00
parent 08d31e0f09
commit 2ce2d145c2
4 changed files with 50 additions and 5 deletions
@@ -1842,13 +1842,20 @@ fn suggest_field_where_appropriate(
            {
                if let ObligationCauseCode::Pattern { span: Some(span), .. } = cause.code {
                    if let Ok(snippet) = self.tcx.sess.source_map().span_to_snippet(span) {
+                        let suggestion = if expected_def.is_struct() {
+                            format!("{}.{}", snippet, name)
+                        } else if expected_def.is_union() {
+                            format!("unsafe {{ {}.{} }}", snippet, name)
+                        } else {
+                            return;
+                        };
                        diag.span_suggestion(
                            span,
                            &format!(
                                "you might have meant to use field `{}` of type `{}`",
                                name, ty
                            ),
-                            format!("{}.{}", snippet, name),
+                            suggestion,
                            Applicability::MaybeIncorrect,
                        );
                    }