From 1dfdfe81495b2d2e5391753bde47b6a93a83a36a Mon Sep 17 00:00:00 2001 From: Yuri Astrakhan Date: Thu, 5 Feb 2026 22:01:40 -0500 Subject: [PATCH 1/3] chore: clearify tidy's error message --- src/tools/tidy/src/ui_tests.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/tools/tidy/src/ui_tests.rs b/src/tools/tidy/src/ui_tests.rs index b5643034d45c..c54feaf33a89 100644 --- a/src/tools/tidy/src/ui_tests.rs +++ b/src/tools/tidy/src/ui_tests.rs @@ -302,7 +302,7 @@ fn deny_new_nondescriptive_test_names( && !stripped_path.starts_with("ui/issues/") { check.error(format!( - "file `tests/{stripped_path}` must begin with a descriptive name, consider `{{reason}}-issue-{issue_n}.rs`", + "the name of the file `tests/{stripped_path}` must begin with a descriptive prefix, consider `{{reason}}-issue-{issue_n}.rs`", issue_n = &test_name[1], )); } From 62d0533eaecb43e75677b954b8c130fd9ffed0f0 Mon Sep 17 00:00:00 2001 From: Yuri Astrakhan Date: Thu, 5 Feb 2026 22:24:22 -0500 Subject: [PATCH 2/3] Update error message for non-descriptive test files --- src/tools/tidy/src/ui_tests.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/tools/tidy/src/ui_tests.rs b/src/tools/tidy/src/ui_tests.rs index c54feaf33a89..59bb35821cb7 100644 --- a/src/tools/tidy/src/ui_tests.rs +++ b/src/tools/tidy/src/ui_tests.rs @@ -302,7 +302,7 @@ fn deny_new_nondescriptive_test_names( && !stripped_path.starts_with("ui/issues/") { check.error(format!( - "the name of the file `tests/{stripped_path}` must begin with a descriptive prefix, consider `{{reason}}-issue-{issue_n}.rs`", + "the name of the file `tests/{stripped_path}` is not descriptive, consider renaming to `{{reason}}-issue-{issue_n}.rs`", issue_n = &test_name[1], )); } From dc87b28bdb4d33a7c458a4dd8c695f7c41948692 Mon Sep 17 00:00:00 2001 From: Yuri Astrakhan Date: Thu, 5 Feb 2026 22:57:11 -0500 Subject: [PATCH 3/3] Improve error message for non-descriptive test names --- src/tools/tidy/src/ui_tests.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/tools/tidy/src/ui_tests.rs b/src/tools/tidy/src/ui_tests.rs index 59bb35821cb7..411cbc17dbc8 100644 --- a/src/tools/tidy/src/ui_tests.rs +++ b/src/tools/tidy/src/ui_tests.rs @@ -302,7 +302,7 @@ fn deny_new_nondescriptive_test_names( && !stripped_path.starts_with("ui/issues/") { check.error(format!( - "the name of the file `tests/{stripped_path}` is not descriptive, consider renaming to `{{reason}}-issue-{issue_n}.rs`", + "issue-number-only test names are not descriptive, consider renaming file `tests/{stripped_path}` to `{{reason}}-issue-{issue_n}.rs`", issue_n = &test_name[1], )); }