From 063b26af6bf7973768d2616eb4f79fc9b91ee11c Mon Sep 17 00:00:00 2001 From: Oli Scherer Date: Mon, 3 Jun 2024 13:28:49 +0000 Subject: [PATCH] Explain some code duplication --- compiler/rustc_hir_analysis/src/hir_ty_lowering/mod.rs | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/compiler/rustc_hir_analysis/src/hir_ty_lowering/mod.rs b/compiler/rustc_hir_analysis/src/hir_ty_lowering/mod.rs index d26ebe9881b8..4b8e12a489c5 100644 --- a/compiler/rustc_hir_analysis/src/hir_ty_lowering/mod.rs +++ b/compiler/rustc_hir_analysis/src/hir_ty_lowering/mod.rs @@ -444,6 +444,8 @@ fn provided_kind( if let Err(incorrect) = self.incorrect_args { if incorrect.invalid_args.contains(&(param.index as usize)) { + // FIXME: use `param.to_error` once `provided_kind` is supplied a list of + // all previous generic args. return match param.kind { GenericParamDefKind::Lifetime => { ty::Region::new_error(tcx, incorrect.reported).into() @@ -531,6 +533,8 @@ fn inferred_kind( if let Err(incorrect) = self.incorrect_args { if incorrect.invalid_args.contains(&(param.index as usize)) { + // FIXME: use `param.to_error` once `inferred_kind` is supplied a list of + // all previous generic args. return match param.kind { GenericParamDefKind::Lifetime => { ty::Region::new_error(tcx, incorrect.reported).into()